Update tests for ska_sun change to position_accurate #201
Conversation
| @@ -629,7 +630,7 @@ def test_roll_options_for_not_allowed_pitch(): | |||
| roll = nominal_roll(ra, dec, date) | |||
| att0 = Quat([ra, dec, roll]) | |||
|
|
|||
| att = apply_sun_pitch_yaw(att0, pitch=40) | |||
| att = apply_sun_pitch_yaw(att0, pitch=40, time=date) | |||
There was a problem hiding this comment.
The new ska_sun breaks on the previous line of code here... which I think was wrong anyway.
There was a problem hiding this comment.
And this change is needed either way... though I think new ska_sun with position_accurate should probably handle the time=None sun_ra=None sun_dec=None case better than an astropy.time ValueError.
There was a problem hiding this comment.
This is a real bug which I have a fix for, PR coming.
jeanconn
changed the title
|
I would have thought we just use the original fast sun positions via a |
|
Though it is probably worth having at least one test that uses the default sun position and then the fast method. The final |
|
I figured that unless you plan to update the application (sparkles) default to use position_fast (a possibility but one we hadn't discussed) that this was a just one-and-done change to the regress data. And having the changes as diffs in github was useful. If you want to keep the position_fast test data as a different functional test I'm not sure I understand the value of that long term. |
Description
Update test expected values for small roll changes caused by change to default method for position in ska_sun.
Interface impacts
Testing
Unit tests
Functional tests
No functional testing.